Skip to content
This repository has been archived by the owner on Feb 13, 2024. It is now read-only.

Handle valid invitation type (didcomm) #623

Merged

Conversation

usingtechnology
Copy link
Contributor

@usingtechnology usingtechnology commented Sep 17, 2021

https://didcomm.org/connections/1.0/invitation is a valid invitation type, so let's handle the current case and this value.
IBM had generated a connection invitation with the didcomm format and we couldn't connect, so we needed to update our invitation parser class.

We can generate invitations with the same @type by starting the agent with --emit-new-didcomm-prefix option.

fixes #620

Signed-off-by: Jason Sherman jsherman@parcsystems.ca

Copy link
Contributor

@etschelp etschelp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can add your examples from #620 to the InvitationParserTest?

Signed-off-by: Jason Sherman <jsherman@parcsystems.ca>
@usingtechnology usingtechnology merged commit 21aea03 into hyperledger-labs:main Sep 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invitation type issue
2 participants