Skip to content
This repository has been archived by the owner on Feb 13, 2024. It is now read-only.

add --legacy-peer-deps flag to all pipelines #771

Merged
merged 3 commits into from
Jun 23, 2022

Conversation

etschelp
Copy link
Contributor

@etschelp etschelp commented Jun 23, 2022

Related to: #759

  • same build params everywhere
  • replaced version pinning with legacy param
  • fixed omit optional dependencies
  • only if developers change dependencies npm install should be used

Signed-off-by: Philipp Etschel <philipp.etschel@ch.bosch.com>
….json

Signed-off-by: Philipp Etschel <philipp.etschel@ch.bosch.com>
Signed-off-by: Philipp Etschel <philipp.etschel@ch.bosch.com>
@etschelp etschelp requested a review from schlagtim June 23, 2022 08:42
Copy link
Contributor

@schlagtim schlagtim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good so far, just the no-optional comments/questions

.github/workflows/build.yml Show resolved Hide resolved
backend/business-partner-agent/pom.xml Show resolved Hide resolved
@schlagtim schlagtim self-requested a review June 23, 2022 10:32
@schlagtim schlagtim merged commit 0e558ff into hyperledger-labs:main Jun 23, 2022
@schlagtim schlagtim mentioned this pull request Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants