Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature file added for import-export cases #520

Merged
merged 2 commits into from
Sep 11, 2023
Merged

Feature file added for import-export cases #520

merged 2 commits into from
Sep 11, 2023

Conversation

shubhamshukla25
Copy link
Contributor

@shubhamshukla25 shubhamshukla25 commented Aug 23, 2023

Type of change

  • Test update: Feature file have been added to test for the import/export-related cases

Description

This change involves writing the step definitions for the import-export cases in the 9-MiscellaneousCases.feature under the packages/apollo/test/functional/features. A folder has been added under the packages/apollo/test/functional/assets containing the exported environment for testing this scenario.

Reviewer: @dshuffma-ibm

@shubhamshukla25 shubhamshukla25 marked this pull request as ready for review August 28, 2023 04:43
@shubhamshukla25 shubhamshukla25 requested a review from a team as a code owner August 28, 2023 04:43
Copy link
Contributor

@dshuffma-ibm dshuffma-ibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you remove the IBP_Import.zip file

shubhamshukla25 and others added 2 commits September 11, 2023 10:50
Signed-off-by: Shubham Shukla <137405501+shubhamshukla25@users.noreply.github.com>
Signed-off-by: Shubham Shukla <shubham.shukla3@ibm.com>
Signed-off-by: Shubham Shukla <shubham.shukla3@ibm.com>
@shubhamshukla25
Copy link
Contributor Author

@dshuffma-ibm I have removed the IBP_Import.zip file. Please review and merge.

Copy link
Contributor

@dshuffma-ibm dshuffma-ibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok thanks, +1

@dshuffma-ibm dshuffma-ibm merged commit a11a37a into hyperledger-labs:main Sep 11, 2023
17 checks passed
selvaprakash92 pushed a commit to selvaprakash92/fabric-operations-console that referenced this pull request Sep 12, 2023
* feature file added for import-export cases
* Feature File updates - changes as per review comments
---------
Signed-off-by: Shubham Shukla <137405501+shubhamshukla25@users.noreply.github.com>
Signed-off-by: Shubham Shukla <shubham.shukla3@ibm.com>
Co-authored-by: Shubham Shukla <shubham.shukla3@ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants