Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decoupling register user button from CA users table #528

Merged
merged 3 commits into from
Sep 19, 2023

Conversation

selvaprakash92
Copy link
Contributor

Type of change

  • New feature

Description

Signed-off-by: Prakash P S <prakashps@Prakashs-MacBook-Pro.local>
@selvaprakash92 selvaprakash92 requested a review from a team as a code owner September 19, 2023 10:13
Copy link
Contributor

@dshuffma-ibm dshuffma-ibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good idea, needs a tweak, see comment

Signed-off-by: Prakash P S <prakashps@Prakashs-MacBook-Pro.local>
Copy link
Contributor

@dshuffma-ibm dshuffma-ibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so close, decoupleFromLoading should be true now

Signed-off-by: Prakash P S <prakashps@Prakashs-MacBook-Pro.local>
@selvaprakash92
Copy link
Contributor Author

@dshuffma-ibm , updated the value to true on both the places

Copy link
Contributor

@dshuffma-ibm dshuffma-ibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@dshuffma-ibm dshuffma-ibm merged commit be0400f into hyperledger-labs:main Sep 19, 2023
@selvaprakash92 selvaprakash92 deleted the decouple-button branch October 12, 2023 05:48
dshuffma-ibm pushed a commit to dshuffma-ibm/fabric-operations-console that referenced this pull request Oct 17, 2023
…#528)

* Included the check at item container
---------
Signed-off-by: Prakash P S <prakashps@Prakashs-MacBook-Pro.local>
Co-authored-by: Prakash P S <prakashps@Prakashs-MacBook-Pro.local>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants