Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abstract multiledger test #355

Merged

Conversation

matthiasgeihs
Copy link
Contributor

Makes the multi-ledger test abstract so that it can be reused in other backends.

@matthiasgeihs matthiasgeihs requested a review from cryptphil June 27, 2022 12:25
Copy link
Member

@cryptphil cryptphil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to make some changes in order to make it work with the Ethereum backend; I already implemented my suggestions in this branch draft/abstract-multiledger-test-PL, except for the balance checking part.

client/test/multiledger_dispute.go Outdated Show resolved Hide resolved
client/test/multiledger_happy.go Outdated Show resolved Hide resolved
client/test/multiledger_dispute.go Show resolved Hide resolved
client/test/multiledger_dispute.go Outdated Show resolved Hide resolved
client/test/multiledger_dispute.go Show resolved Hide resolved
@matthiasgeihs matthiasgeihs requested a review from cryptphil July 13, 2022 13:14
@matthiasgeihs matthiasgeihs force-pushed the abstract-multiledger-test branch from c4ae289 to 3760819 Compare July 15, 2022 13:00
Signed-off-by: Matthias Geihs <matthias@perun.network>
Signed-off-by: Matthias Geihs <matthias@perun.network>
Signed-off-by: Matthias Geihs <matthias@perun.network>
Signed-off-by: Matthias Geihs <matthias@perun.network>
Signed-off-by: Matthias Geihs <matthias@perun.network>
Signed-off-by: Matthias Geihs <matthias@perun.network>
Signed-off-by: Matthias Geihs <matthias@perun.network>
Signed-off-by: Matthias Geihs <matthias@perun.network>
Signed-off-by: Matthias Geihs <matthias@perun.network>
Signed-off-by: Matthias Geihs <matthias@perun.network>
Signed-off-by: Matthias Geihs <matthias@perun.network>
Signed-off-by: Matthias Geihs <matthias@perun.network>
Signed-off-by: Matthias Geihs <matthias@perun.network>
Signed-off-by: Matthias Geihs <matthias@perun.network>
Signed-off-by: Matthias Geihs <matthias@perun.network>
Signed-off-by: Matthias Geihs <matthias@perun.network>
Signed-off-by: Matthias Geihs <matthias@perun.network>
@matthiasgeihs matthiasgeihs force-pushed the abstract-multiledger-test branch from 3760819 to 955c80c Compare July 15, 2022 13:02
Copy link
Member

@cryptphil cryptphil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 🚀

@matthiasgeihs matthiasgeihs merged commit 055abf1 into hyperledger-labs:main Jul 15, 2022
@matthiasgeihs matthiasgeihs deleted the abstract-multiledger-test branch July 15, 2022 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants