This repository has been archived by the owner on Nov 7, 2023. It is now read-only.
Support obtaining and resetting the message log #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 17, 2021 19:41
It does not seem useful to have the internal lock as a named field since the structure is not exported. Signed-off-by: Sergey Fedorov <sergey.fedorov@neclab.eu>
This change simplifies the code and makes it more efficient. Signed-off-by: Sergey Fedorov <sergey.fedorov@neclab.eu>
nhoriguchi
reviewed
Jun 20, 2021
| sync.RWMutex | ||
|
|
||
| // Value incremented on each reset | ||
| epoch uint64 |
There was a problem hiding this comment.
This field is used to detect Reset() calls during supplyMessages(). So naming this more directly like "reset" might be suitable? I think that the word "epoch" can be used to represent the similar concept as "view", so it might be confusing for someone familiar with other consensus protocols.
There was a problem hiding this comment.
I decided to replace it with a channel.
added 2 commits
June 21, 2021 16:20
This method will be required to generate ViewChange message. Signed-off-by: Sergey Fedorov <sergey.fedorov@neclab.eu>
This method will allow to replace the content of the log with ViewChange/NewView messages which embed the preceding messages. Signed-off-by: Sergey Fedorov <sergey.fedorov@neclab.eu>
sergefdrv
force-pushed
the
message-log-extension
branch
from
538c814 to
c3ba51d
Compare
|
Summary of changes:
|
nhoriguchi
reviewed
Jun 22, 2021
nhoriguchi
approved these changes
Jun 22, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request extends the message log functionality required to generate
ViewChangemessages.