Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PDO tag should be customizable for various samples #6

Open
prakashngit opened this issue Sep 25, 2023 · 1 comment
Open

PDO tag should be customizable for various samples #6

prakashngit opened this issue Sep 25, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@prakashngit
Copy link
Contributor

PDO tag used for various contracts should be customizable, rather than forcing all examples within this folder to use the same PDO version.

Best to export the PDO version as part of the installation of the contract, and check whether the required PDO version is installed. Also, perhaps no need to carry PDO as a submodule of the contracts folder itself.

@prakashngit prakashngit changed the title PDO tag should be PDO tag should be customizable for various samples Sep 25, 2023
@prakashngit prakashngit added the enhancement New feature or request label Sep 25, 2023
@cmickeyb
Copy link
Contributor

cmickeyb commented Oct 4, 2023

I don't know why we would want to support multiple versions of the PDO source for different contract families. It seems like that would 1) make automated testing impossibly complex 2) make it extremely difficult for anyone who wants to use the contracts, 3) be inconsistent with any attempt at broad deployment.

Personally, I think a much better approach is to require all contract families to support the same version of PDO. This means that anyone who contributes a contract family will be responsible to continue to provide updates. When new versions of PDO come out, we should make a branch with the new version until all contract families pass their own automated tests.

cmickeyb added a commit to cmickeyb/pdo-contracts that referenced this issue Dec 19, 2024
Signed-off-by: Mic Bowman <cmickeyb@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants