fix: change owner & adjudicator address to immutable

Signed-off-by: Sophia Koehler <sophia@perun.network>
hyperledger-labs · Jan 3, 2025 · 1410701 · 1410701
1 parent 2f85c50
commit 1410701
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/contracts/AssetHolder.sol b/contracts/AssetHolder.sol
@@ -61,7 +61,7 @@ abstract contract AssetHolder {
      * @notice Address of the adjudicator contract that can call setOutcome.
      * @dev Set by the constructor.
      */
-    address public adjudicator;
+    address public immutable adjudicator;
 
     /**
      * @notice The onlyAdjudicator modifier specifies functions that can only be called from the adjudicator contract.

diff --git a/contracts/AssetHolderETH.sol b/contracts/AssetHolderETH.sol
@@ -46,11 +46,12 @@ contract AssetHolderETH is AssetHolder {
      * @notice Should not be called directly but only by the parent AssetHolder.
      * @dev Withdraws ethereum for channel participant authorization.participant
      * to authorization.receiver.
-     * @param authorization Withdrawal Authorization to authorize token transer
+     * @param authorization Withdrawal Authorization to authorize token transfer
      * from a channel participant to an on-chain receiver.
      */
     //slither-disable-next-line dead-code
     function withdrawEnact(WithdrawalAuth calldata authorization, bytes calldata) internal override {
+        //slither-disable-next-line arbitrary-send-eth
         authorization.receiver.transfer(authorization.amount);
     }
 }
diff --git a/contracts/Migrations.sol b/contracts/Migrations.sol
@@ -17,7 +17,7 @@
 pragma solidity ^0.8.15;
 
 contract Migrations {
-    address public owner;
+    address public immutable owner;
     uint public lastCompletedMigration;
 
     constructor() {