-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove channelID array #41
Open
sophia1ch
wants to merge
14
commits into
hyperledger-labs:main
Choose a base branch
from
perun-network:remove-channelID-array
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Remove channelID array #41
sophia1ch
wants to merge
14
commits into
hyperledger-labs:main
from
perun-network:remove-channelID-array
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dhat Signed-off-by: Ilja von Hoessle <ilja@perun.network>
Signed-off-by: Ilja von Hoessle <ilja@perun.network>
…ment Channels Signed-off-by: Ilja von Hoessle <ilja@perun.network>
Signed-off-by: Sophia Koehler <sophia@perun.network>
Signed-off-by: Sophia Koehler <sophia@perun.network>
feat(adjudicator, assetholder): optimize gas usage feat: remove safemath usage, over- and underflows are checked automatically since solidity 0.8.0 fix(test): remove pubkey from participant Signed-off-by: Sophia Koehler <sophia@perun.network>
Signed-off-by: Sophia Koehler <sophia@perun.network>
Signed-off-by: Sophia Koehler <sophia@perun.network>
Signed-off-by: Sophia Koehler <sophia@perun.network>
Signed-off-by: Sophia Koehler <sophia@perun.network>
Signed-off-by: Sophia Koehler <sophia@perun.network>
Signed-off-by: Sophia Koehler <sophia@perun.network>
…nnecessary functions Signed-off-by: Sophia Koehler <sophia@perun.network>
fix(ci.yaml): Add immutable-state to slither exclusion Signed-off-by: Sophia Koehler <sophia@perun.network>
As far as I can see, this goes on top of #40. In this case, you would typically target branch perun-network:feat-crosschain in the PR. Then it's clear what is new in #41 and what is old (i.e., already was there in #40). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends and optimizes #40 by removing the channelID array. The need for multiple channelIDs was eliminated by adding Ethereum encoding support to our other backends.