Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove channelID array #41

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

sophia1ch
Copy link

This PR extends and optimizes #40 by removing the channelID array. The need for multiple channelIDs was eliminated by adding Ethereum encoding support to our other backends.

iljabvh and others added 14 commits August 7, 2024 14:34
…dhat

Signed-off-by: Ilja von Hoessle <ilja@perun.network>
Signed-off-by: Ilja von Hoessle <ilja@perun.network>
…ment Channels

Signed-off-by: Ilja von Hoessle <ilja@perun.network>
Signed-off-by: Sophia Koehler <sophia@perun.network>
Signed-off-by: Sophia Koehler <sophia@perun.network>
feat(adjudicator, assetholder): optimize gas usage
feat: remove safemath usage, over- and underflows are checked automatically since solidity 0.8.0
fix(test): remove pubkey from participant

Signed-off-by: Sophia Koehler <sophia@perun.network>
Signed-off-by: Sophia Koehler <sophia@perun.network>
Signed-off-by: Sophia Koehler <sophia@perun.network>
Signed-off-by: Sophia Koehler <sophia@perun.network>
Signed-off-by: Sophia Koehler <sophia@perun.network>
Signed-off-by: Sophia Koehler <sophia@perun.network>
Signed-off-by: Sophia Koehler <sophia@perun.network>
…nnecessary functions

Signed-off-by: Sophia Koehler <sophia@perun.network>
fix(ci.yaml): Add immutable-state to slither exclusion

Signed-off-by: Sophia Koehler <sophia@perun.network>
@matthiasgeihs
Copy link
Contributor

As far as I can see, this goes on top of #40. In this case, you would typically target branch perun-network:feat-crosschain in the PR. Then it's clear what is new in #41 and what is old (i.e., already was there in #40).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants