Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve debugging of failed tests during github workflows #455

Merged
merged 5 commits into from
Dec 5, 2023
Merged

Improve debugging of failed tests during github workflows #455

merged 5 commits into from
Dec 5, 2023

Conversation

cmickeyb
Copy link
Contributor

@cmickeyb cmickeyb commented Dec 5, 2023

Several fixes/improvements:

  • debug logging is now available in the docker/docker compose tests
  • when logging is enabled, unit tests will now generate output, respects environment variables
  • github commits can add '[debug]' to turn on debug build/logging during runs
  • fix sgx ssl abort when running actions on non-intel processors (skip the CPU check in SIM mode)

@cmickeyb
update sgx, openssl, and sgxssl
26d59f3 
Signed-off-by: Mic Bowman <mic.bowman@intel.com>
@cmickeyb
Push PDO_LOG_LEVEL and PDO_DEBUG_BUILD parameters into docker builds
898452f 
To simplify collection of logging during testing, add
support for PDO_LOG_LEVEL and PDO_DEBUG_BUILD throughout
the docker and docker compose configuration files. By
default, these will be copied from the environment during
the build.

Signed-off-by: Mic Bowman <mic.bowman@intel.com>
@cmickeyb
Expose unit test results when PDO_LOG_LEVEL is set to debug
4c18fad 
When PDO_LOG_LEVEL is set to debug, turn on verbose logging
in cmake tests and push the logs to the screen.

Signed-off-by: Mic Bowman <mic.bowman@intel.com>
@cmickeyb
Support debug logging in github runners
7b0bc4c 
Adding the string '[debug]' to a commit message
will cause github runner to build docker images
using debug build and will turn on all logging.
This should simplify debugging of issues that show
up on github and not in local test environments.

Signed-off-by: Mic Bowman <mic.bowman@intel.com>
@cmickeyb
Fix a problem with non-intel cpus
18ef23d 
By default SGX SSL checks for Intel CPU even in SIM
mode. This sets a flag to avoid that check when running
in SIM mode.

Fixes the problem of github runners failing in the
common library unit tests.

Signed-off-by: Mic Bowman <mic.bowman@intel.com>
marcelamelara
marcelamelara approved these changes Dec 5, 2023
View reviewed changes
Copy link
Member

@marcelamelara marcelamelara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks!!

bvavala
bvavala approved these changes Dec 5, 2023
View reviewed changes
Copy link
Member

@bvavala bvavala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@bvavala bvavala merged commit 995474c into hyperledger-labs:main Dec 5, 2023
4 checks passed
@cmickeyb cmickeyb deleted the mic.dec05.fix_sgx_ssl_abort branch January 16, 2024 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcelamelara marcelamelara marcelamelara approved these changes

@bvavala bvavala bvavala approved these changes

Assignees

@bvavala bvavala

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cmickeyb @bvavala @marcelamelara