Fix assert statements and deprecated logger.warn's #486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he error handling/reporting Signed-off-by: Bruno Vavala <bruno.vavala@intel.com>
Signed-off-by: Bruno Vavala <bruno.vavala@intel.com>
cmickeyb
requested changes
Apr 23, 2024
| @@ -76,7 +77,7 @@ def verify_store_signature(store_response, duration, verifying_key) : | |||
| result = client.store_blocks([block_data], duration=default_duration) | |||
| assert result | |||
|
|
|||
| assert verify_store_signature(result, default_duration, client.verifying_key) | |||
| assert (1 == verify_store_signature(result, default_duration, client.verifying_key)) | |||
|
|
|||
There was a problem hiding this comment.
why are we using assert here? it pretty much blows up the entire application. can we just use the existing exceptions? the whole value of returning multiple values is to distinguish between invalid and error but you are throwing the same error both ways; as in this tells it breaks but not why
| @@ -109,7 +110,7 @@ def verify_store_signature(store_response, duration, verifying_key) : | |||
| result = client.store_blocks(block_data, duration=default_duration) | |||
| assert result | |||
|
|
|||
| assert verify_store_signature(result, default_duration, client.verifying_key) | |||
| assert (1 == verify_store_signature(result, default_duration, client.verifying_key)) | |||
|
|
|||
There was a problem hiding this comment.
same. this is pretty draconian.
I have changed the assert's in the file with raises's. |
Signed-off-by: Bruno Vavala <bruno.vavala@intel.com>
bvavala
force-pushed
the
bruno.240423.fix-asserts-and-warns
branch
from
5416289 to
e6e5088
Compare
cmickeyb
approved these changes
Apr 23, 2024
prakashngit
approved these changes
Apr 23, 2024
This was referenced Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #288 and #484 .