Several small cleanups #491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The wait_parameter_for_ledger value is not used with CCF. This removes it. Signed-off-by: Mic Bowman <mic.bowman@intel.com>
Signed-off-by: Mic Bowman <mic.bowman@intel.com>
Add a get_value method to get the raw value of the context. Then this is used to get context information for the contract collections (which means that the top level contexts are not expanded when they are placed in the contract collection. Signed-off-by: Mic Bowman <mic.bowman@intel.com>
Signed-off-by: Mic Bowman <mic.bowman@intel.com>
prakashngit
approved these changes
May 22, 2024
Signed-off-by: Mic Bowman <mic.bowman@intel.com>
Signed-off-by: Mic Bowman <mic.bowman@intel.com>
bvavala
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several small python clean ups.
Only significant behavior change would be in contract collections where top level contexts will not be expanded. Which means that references in the contexts will be preserved.