Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Execute docker workflow on dispatch only #505

Merged
merged 1 commit into from
Oct 30, 2024
Merged

Execute docker workflow on dispatch only #505

merged 1 commit into from
Oct 30, 2024

Conversation

cmickeyb
Copy link
Contributor

No description provided.

@cmickeyb cmickeyb force-pushed the mic.oct30.github_workflows branch from cac3e39 to 3a04675 Compare October 30, 2024 15:53
@cmickeyb cmickeyb requested a review from g2flyer October 30, 2024 16:05
@cmickeyb cmickeyb assigned cmickeyb and g2flyer and unassigned cmickeyb Oct 30, 2024
@cmickeyb cmickeyb marked this pull request as ready for review October 30, 2024 16:09
g2flyer
g2flyer approved these changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@g2flyer g2flyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to have it triggered manually only for now and corresponding change looks good (only thing comes in mind is that i was wondering whether you had to comment out the if; so re-enabling could not mistakenly be attempted only by uncommenting the first section but forgetting the second; alternatively, a comment in the first section noting the dependency on the second comment section could also make it more robust). But no strong feeling; just couldn't resist to give some 5 cents ;-)

@cmickeyb cmickeyb force-pushed the mic.oct30.github_workflows branch from 3a04675 to 419d785 Compare October 30, 2024 20:51
@cmickeyb
Fix the docker workflow
ec447e3 
Two issues... first, moved the docker workflow to be triggered
exclusively through interactive request. The policy for automated
triggering can be determined at a later time.

Second, fixed a couple bugs in the docker workflow. Now that the
workflow is a part of the main branch, debugging is far easier.

Note that this is been tested on a personal repository but not
on an organizational repository such as hyperledger.

Signed-off-by: Mic Bowman <mic.bowman@intel.com>
@cmickeyb cmickeyb force-pushed the mic.oct30.github_workflows branch from 419d785 to ec447e3 Compare October 30, 2024 21:09
@cmickeyb cmickeyb changed the title Test docker workflow on dispatch only Execute docker workflow on dispatch only Oct 30, 2024
@cmickeyb
Copy link
Contributor Author

Makes sense to have it triggered manually only for now and corresponding change looks good (only thing comes in mind is that i was wondering whether you had to comment out the if; so re-enabling could not mistakenly be attempted only by uncommenting the first section but forgetting the second; alternatively, a comment in the first section noting the dependency on the second comment section could also make it more robust). But no strong feeling; just couldn't resist to give some 5 cents ;-)

Added comments to the workflow. Thanks for the suggestions!

@g2flyer g2flyer merged commit 5e487ce into hyperledger-labs:main Oct 30, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@g2flyer g2flyer g2flyer approved these changes

Assignees

@g2flyer g2flyer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cmickeyb @g2flyer