Sbile/signing provider store support #736
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
October 15, 2025 23:40
- Add SigningDriverStore interface for persistent storage of signing data - Implement SigningDriverProxy to wrap drivers with persistence capabilities - Add SigningDriverFactory interface and registry for driver management - Create factory implementations for Fireblocks, Internal, and Participant drivers - Add SQL schema migrations for signing driver data storage - Implement batch operations for keys, transactions, and configuration - Add support for driver-specific metadata and configuration persistence - Enable caching of signing operations with fallback to underlying drivers Signed-off-by: Vasilis Dialinos <vasilis.dialinos@lifescale.me>
…r-store-support Signed-off-by: Vasilis Dialinos <vasilis.dialinos@lifescale.me>
Signed-off-by: Vasilis Dialinos <vasilis.dialinos@lifescale.me>
| userId: string, | ||
| keyId: string | ||
| ): Promise< | ||
| import('@canton-network/core-signing-lib').SigningKey | undefined |
There was a problem hiding this comment.
move imports to the top for readability
Comment on lines
+373
to
+376
| console.log( | ||
| 'setSigningKey - serialized data:', | ||
| JSON.stringify(serialized, null, 2) | ||
| ) |
There was a problem hiding this comment.
@mjuchli-da do you know if we should be using pino or a generalized logger?
| @@ -0,0 +1,96 @@ | |||
| // Copyright (c) 2025 Digital Asset (Switzerland) GmbH and/or its affiliates. All rights reserved. | |||
There was a problem hiding this comment.
Think git lost track of this with the file being moved + renamed -- the changes here should be diff'd and applied now to wallet-gateway/remote/src/init.ts
|
Current state:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.