Substrate: Support contracts node v0.22 #1080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Cyrill Leutwiler <bigcyrill@hotmail.com>
Signed-off-by: xermicus <cyrill@parity.io>
Signed-off-by: xermicus <cyrill@parity.io>
Signed-off-by: xermicus <cyrill@parity.io>
Signed-off-by: Cyrill Leutwiler <bigcyrill@hotmail.com>
Signed-off-by: xermicus <cyrill@parity.io>
Signed-off-by: xermicus <cyrill@parity.io>
Signed-off-by: xermicus <cyrill@parity.io>
Signed-off-by: xermicus <cyrill@parity.io>
Signed-off-by: xermicus <cyrill@parity.io>
Signed-off-by: Cyrill Leutwiler <bigcyrill@hotmail.com>
Signed-off-by: xermicus <cyrill@parity.io>
Signed-off-by: xermicus <cyrill@parity.io>
xermicus
changed the title
seanyoung
reviewed
Nov 25, 2022
| @@ -5,7 +5,7 @@ | |||
| "main": "index.js", | |||
| "scripts": { | |||
| "test": "tsc; ts-mocha -t 20000 *.spec.ts", | |||
| "build": "solang compile *.sol test/*.sol --target substrate -v" | |||
| "build": "parallel solang compile -v --target substrate ::: *.sol test/*.sol" | |||
There was a problem hiding this comment.
We should make solang parallel at some point
There was a problem hiding this comment.
Good idea, I imagine compiling all contracts in parallel should be easy to do
seanyoung
reviewed
Nov 25, 2022
integration/substrate/package.json
Outdated
| @@ -5,7 +5,7 @@ | |||
| "main": "index.js", | |||
| "scripts": { | |||
| "test": "tsc; ts-mocha -t 20000 *.spec.ts", | |||
| "build": "solang compile *.sol test/*.sol --target substrate -v" | |||
| "build": "parallel solang compile -v --target substrate ::: *.sol test/*.sol" | |||
| }, | |||
| "author": "Sean Young <sean@mess.org>", | |||
There was a problem hiding this comment.
This really needs updating, you could add your name here (I think it has to be contributors rather than author.
seanyoung
approved these changes
Nov 25, 2022
Signed-off-by: Cyrill Leutwiler <bigcyrill@hotmail.com>
LucasSte
approved these changes
Nov 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
__unstable__queryAPIWeightV2for gas limitslatestcontracts CI image for pallet contracts v0.22.1. I'm aware that this is not ideal but it's what's available right now. There shouldn't be a breaking release soon, we can switch toproductionas soon as its here.