-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump polkadot node version #1617
Bump polkadot node version #1617
Conversation
Signed-off-by: Cyrill Leutwiler <bigcyrill@hotmail.com>
Signed-off-by: Cyrill Leutwiler <bigcyrill@hotmail.com>
…dot where the runtime now logs the API calls and return codes Signed-off-by: Cyrill Leutwiler <bigcyrill@hotmail.com>
Signed-off-by: Cyrill Leutwiler <bigcyrill@hotmail.com>
Signed-off-by: Cyrill Leutwiler <bigcyrill@hotmail.com>
Signed-off-by: Cyrill Leutwiler <bigcyrill@hotmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1617 +/- ##
==========================================
- Coverage 88.44% 88.43% -0.02%
==========================================
Files 150 150
Lines 68322 68200 -122
==========================================
- Hits 60429 60311 -118
+ Misses 7893 7889 -4 ☔ View full report in Codecov by Sentry. |
@@ -3,6 +3,7 @@ import { weight, createConnection, deploy, transaction, aliceKeypair, daveKeypai | |||
import { ContractPromise } from '@polkadot/api-contract'; | |||
import { ApiPromise } from '@polkadot/api'; | |||
|
|||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
random line add
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed
src/emit/polkadot/storage.rs
Outdated
log_return_code(binary, "seal_get_storage", exists); | ||
|
||
let exists = binary.builder.build_int_compare( | ||
let condition = binary.builder.build_int_compare( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
exists
was supposed to mean "does the key exist". condition
is not very clear
src/emit/polkadot/target.rs
Outdated
log_return_code(binary, "seal_get_storage: ", exists); | ||
|
||
let exists = binary.builder.build_int_compare( | ||
let condition = binary.builder.build_int_compare( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
exists
was supposed to mean "does the key exist". condition
is not very clear
Signed-off-by: Cyrill Leutwiler <bigcyrill@hotmail.com>
Upgrade the Polkadot node. In recent versions, the node (in debug mode) logs any API calls and their results to debug buffer on its own. Because this feature was only relevant in the Polkadot target, I 🪓 it.