Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump inkwell and other crates #1622

Merged
merged 1 commit into from
Feb 6, 2024
Merged

Conversation

seanyoung
Copy link
Contributor

@seanyoung seanyoung commented Feb 4, 2024

Update crates dependencies and fix the CI problems.

Signed-off-by: Sean Young <sean@mess.org>
Copy link

codecov bot commented Feb 4, 2024

Codecov Report

Attention: 78 lines in your changes are missing coverage. Please review.

Comparison is base (0f032dc) 88.43% compared to head (24dcda9) 88.58%.
Report is 2 commits behind head on main.

Files Patch % Lines
src/emit/instructions.rs 87.26% 34 Missing ⚠️
src/emit/binary.rs 81.41% 21 Missing ⚠️
src/emit/strings.rs 92.26% 14 Missing ⚠️
src/emit/polkadot/storage.rs 98.78% 3 Missing ⚠️
src/emit/expression.rs 99.68% 2 Missing ⚠️
src/emit/solana/target.rs 99.66% 2 Missing ⚠️
src/emit/polkadot/target.rs 99.72% 1 Missing ⚠️
src/emit/soroban/target.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1622      +/-   ##
==========================================
+ Coverage   88.43%   88.58%   +0.15%     
==========================================
  Files         150      150              
  Lines       68200    69335    +1135     
==========================================
+ Hits        60311    61420    +1109     
- Misses       7889     7915      +26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@seanyoung seanyoung marked this pull request as ready for review February 5, 2024 08:48
Copy link
Contributor

@xermicus xermicus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@@ -28,12 +28,12 @@ tiny-keccak = { version = "2.0", features = ["keccak"] }
serde_json = "1.0"
serde = "1.0"
serde_derive = { version = "1.0" }
inkwell = { version = "0.2.0", features = ["target-webassembly", "no-libffi-linking", "llvm16-0"], optional = true }
inkwell = { version = "0.4.0", features = ["target-webassembly", "no-libffi-linking", "llvm16-0"], optional = true }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since inkwell 0.3.0 introduced support for LLVM 17 we could switch to LLVM 17 too in the near future WDYT?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Totally, that's one reason I wanted to update inkwell

@seanyoung seanyoung merged commit d7a875a into hyperledger-solang:main Feb 6, 2024
20 checks passed
@seanyoung seanyoung deleted the bump branch February 6, 2024 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants