Fix panics caused by shifting(#1618) #1627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YancyParker
requested review from
seanyoung,
xermicus and
LucasSte
as code owners
YancyParker
force-pushed
the
fix/shiftExpression
branch
2 times, most recently
from
93a8942
to
466fbbf
Compare
seanyoung
reviewed
Mar 1, 2024
Ok, I will add a test case. |
Signed-off-by: yp945 <pan107104@outlook.com>
YancyParker
force-pushed
the
fix/shiftExpression
branch
from
466fbbf
to
f33fbaa
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1627 +/- ##
==========================================
- Coverage 88.58% 88.58% -0.01%
==========================================
Files 150 150
Lines 69331 69342 +11
==========================================
+ Hits 61416 61424 +8
- Misses 7915 7918 +3 ☔ View full report in Codecov by Sentry. |
|
I have successfully run the |
It was an intermittent failure in the integration tests. Rerunning it fixed the problem. |
LucasSte
approved these changes
Mar 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the bug where there was no load when the right expression of the shift calculation is a structure member.