Feature/364 integretion with hsm #1602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
| } else { | ||
| signedMessage = PrivateTransactionEncoder.signMessage(rawTransaction, credentials); | ||
| } | ||
| final byte[] signedMessage = txSignService.sign(rawTransaction, chainId); |
There was a problem hiding this comment.
Hi @andrii-kl , I think this change is not ok since it gets rid of the PrivateTransactionEncoder to replace it with the regular TransactionEncoder within TxSignServiceImpl .
I have run some tests in Besu using 4.9.3 and indeed the signature is different.
Let me know if I am missing something, otherwise probably it would be good to open an issue for the fix.
Thanks in advance, Miguel.
There was a problem hiding this comment.
just spotted this also! #1747
There was a problem hiding this comment.
Thanks for creating the issue @antonydenyer ! If @andrii-kl is not available I could take the implementation of the fix.
|
Is there any documentation about how to use this with a hardware wallet? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add functionality to work with HSM (hardware security module). Reference implementation of working with HSM over HTTP
Why is it needed?
To sign transactions with hard wallet / HSM (hardware security module)