Feature/1603 ens offchain integration

[andrii-kl]

What does this PR do?

Add support of new functions of ENS. eip-3668 | EIP 1577

Why is it needed?

To work with new ENS functions.

[makoto]

Hi @andrii-kl thanks for the integration PR and sorry for not being able to respond quickly.
I have a couple of comments

1. Does it have any usage example in doc or in the test?
2. Could you test with real data 1.offchainexample.eth as described in our doc and see if it returns the record as expected?

Thanks.

Makoto

[makoto]

FYI. Added some test casce snenario for web3.py which you can refer to as well ethereum/web3.py#2406

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[andrii-kl]

@makoto
I have change a bit my realisation according to example from
https://docs.ens.domains/ens-improvement-proposals/ensip-10-wildcard-resolution
but I have an error when I try to call resolver.resolve(dnsEncodedName, calldata)

"Contract Call has been reverted by the EVM with the reason: 'execution reverted'."

[andrii-kl]

@makoto Same response in the etherscan too. (ensName: 1.offchainexample.eth)

Could you provide right execution parameters for this method? (1.offchainexample.eth)

[gtebrean]

looks good for me, only few questions

[gtebrean]

shouldn't this be generated with a newer version?

[gtebrean]

shouldn't this be generated with a newer version?

[makoto]

@makoto Same response in the etherscan too. (ensName: 1.offchainexample.eth)

Could you provide right execution parameters for this method? (1.offchainexample.eth)

That should show custom error type with gateway URL like the below as long as you put two bytecode

     Error: call revert exception [ See: https://links.ethers.org/v5-errors-CALL_EXCEPTION ] (method="resolve(bytes,bytes)", errorArgs=["0x5FbDB2315678afecb367f032d93F642f64180aa3",["http://localhost:8080/"],"0x9061b92300000000000000000000000000000000000000000000000000000000000000400000000000000000000000000000000000000000000000000000000000000080000000000000000000000000000000000000000000000000000000000000001701310f6f6666636861696e6578616d706c6503657468000000000000000000000000000000000000000000000000000000000000000000000000000000000000","0xf4d4d2f8","0x9061b92300000000000000000000000000000000000000000000000000000000000000400000000000000000000000000000000000000000000000000000000000000080000000000000000000000000000000000000000000000000000000000000001701310f6f6666636861696e6578616d706c6503657468000000000000000000000000000000000000000000000000000000000000000000000000000000000000"], errorName="OffchainLookup", errorSignature="OffchainLookup(address,string[],bytes,bytes4,bytes)", reason=null, code=CALL_EXCEPTION, version=abi/5.6.0)
```

For some reason, it's not showing as you demonstrated. Let me check with etherscan team if they do support showing custom error type

[andrii-kl]

@makoto Same response in the etherscan too. (ensName: 1.offchainexample.eth)
Could you provide right execution parameters for this method? (1.offchainexample.eth)

That should show custom error type with gateway URL like the below as long as you put two bytecode

     Error: call revert exception [ See: https://links.ethers.org/v5-errors-CALL_EXCEPTION ] (method="resolve(bytes,bytes)", errorArgs=["0x5FbDB2315678afecb367f032d93F642f64180aa3",["http://localhost:8080/"],"0x9061b92300000000000000000000000000000000000000000000000000000000000000400000000000000000000000000000000000000000000000000000000000000080000000000000000000000000000000000000000000000000000000000000001701310f6f6666636861696e6578616d706c6503657468000000000000000000000000000000000000000000000000000000000000000000000000000000000000","0xf4d4d2f8","0x9061b92300000000000000000000000000000000000000000000000000000000000000400000000000000000000000000000000000000000000000000000000000000080000000000000000000000000000000000000000000000000000000000000001701310f6f6666636861696e6578616d706c6503657468000000000000000000000000000000000000000000000000000000000000000000000000000000000000"], errorName="OffchainLookup", errorSignature="OffchainLookup(address,string[],bytes,bytes4,bytes)", reason=null, code=CALL_EXCEPTION, version=abi/5.6.0)

For some reason, it's not showing as you demonstrated. Let me check with etherscan team if they do support showing custom error type

Yes, it would be great to add support on the etherscan.

On our side, everything is fine, we have dealt with everything, thank you.