Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DO NOT MERGE add trace call many #1626

Merged

Conversation

frankisawesome
Copy link
Contributor

What does this PR do?

required

Where should the reviewer start?

required

Why is it needed?

required

@frankisawesome frankisawesome marked this pull request as draft February 15, 2022 06:13
@frankisawesome frankisawesome marked this pull request as ready for review February 15, 2022 23:23
@frankisawesome
Copy link
Contributor Author

hey @conor10 any chance you can approve the CI run?
note that this is missing a test because the test file doesn't compile out of the box locally with Cannot resolve method 'verifyResult' in 'RequestTest'

@mohamedelshami mohamedelshami merged commit a5768a7 into hyperledger-web3j:master Feb 15, 2022
@mohamedelshami mohamedelshami self-requested a review February 15, 2022 23:29
@frankisawesome
Copy link
Contributor Author

Any chance you could merge the revert so master is not broken and we can test out the build with a new PR @mohamedelshami ? Would also love some help getting started as the PR currently doesn't build and we're having some difficulties building locally, for context we're adding a Parity api missing that's very similar to an existing one.

@mohamedelshami
Copy link
Contributor

@frankisawesome there was another issue with the build earlier which prevented this PR from completing the build.

I see the revert already merged. Let me know how else we can help to get this going.

@frankisawesome
Copy link
Contributor Author

For the record I don't think the changes have been reverted, see 23ecc2a
the changes here are on master

@mohamedelshami
Copy link
Contributor

@frankisawesome that's odd, I thought it would've been merged already after the revert, but it's now been pushed along with a more recent commit.

Is it easier if you raise a new PR rolling forward the changes that you like to see in Partiy API?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants