Fix retrieval of revert reason by using the same weiAmount in the call. #1656
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It fixes the retrieval of the tx revert reason, by using the same weiValue amount that was used in the failed transaction.
Where should the reviewer start?
Consider this simplified test case contract:
Then call it with
n == 2
andweiAmount == 1
, and you'll get a super misleadingmsg.value must be positive
error message.Why is it needed?
Because it drove me crazy for 24h to debug a complex smart contract when the thrown errors were in completely different code locations.