Add AccessList to 1559 transaction rlp encoding #1992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @liewhite your PR is really useful, in order to can merge it could you please fix the build issues by fixing the tests? thanks |
Signed-off-by: Nischal Sharma <nischal@web3labs.com>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1992 +/- ##
============================================
- Coverage 68.69% 68.61% -0.09%
+ Complexity 3041 3040 -1
============================================
Files 490 490
Lines 12715 12726 +11
Branches 1653 1653
============================================
- Hits 8735 8732 -3
- Misses 3497 3509 +12
- Partials 483 485 +2 ☔ View full report in Codecov by Sentry. |
gtebrean
reviewed
Feb 2, 2024
| return chainId; | ||
| @Override | ||
| public BigInteger getGasPrice() { | ||
| throw new UnsupportedOperationException("not available for 1559 transaction"); |
There was a problem hiding this comment.
Should be nice to have a test case for this
Comment on lines
+47
to
+50
| super(chainId, nonce, null, gasLimit, to, value, data, Collections.emptyList()); | ||
| this.maxPriorityFeePerGas = maxPriorityFeePerGas; | ||
| this.maxFeePerGas = maxFeePerGas; | ||
| } |
There was a problem hiding this comment.
Even if it looks simple a test case will be worth here, also will improve the test coverage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add AccessList to 1559 transaction
Where should the reviewer start?
org.web3j.crypto.transaction.type.Transaction1559Why is it needed?
#1991
It's an omission in web3j