-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug fix for FastRawTransactionManager.resetNonce #2084
Merged
Merged
+96
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@junsung-cho Looks good to me, please also update the changelog.md and I will merge it |
@gtebrean I updated CHANGELOG.md, thanks |
@gtebrean Integration test failed, but I don't know why.
|
It is a bit flaky test, I will rerun it |
NickSneo
requested changes
Jul 30, 2024
Signed-off-by: Junsung Cho <junsung@directional.net>
NickSneo
reviewed
Aug 9, 2024
integration-tests/src/test/java/org/web3j/protocol/scenarios/FastRawTransactionManagerIT.java
Show resolved
Hide resolved
Signed-off-by: Junsung Cho <junsung@directional.net>
shashankiitbhu
pushed a commit
to shashankiitbhu/web3j
that referenced
this pull request
Dec 2, 2024
) * Bug fix for FastRawTransactionManager.resetNonce Signed-off-by: Junsung Cho <junsung@directional.net> * Add check nonce after reset Signed-off-by: Junsung Cho <junsung@directional.net> --------- Signed-off-by: Junsung Cho <junsung@directional.net> Signed-off-by: Shashank Kumar <shashank.kumar.phe22@itbhu.ac.in>
shashankiitbhu
pushed a commit
to shashankiitbhu/web3j
that referenced
this pull request
Dec 2, 2024
) * Bug fix for FastRawTransactionManager.resetNonce Signed-off-by: Junsung Cho <junsung@directional.net> * Add check nonce after reset Signed-off-by: Junsung Cho <junsung@directional.net> --------- Signed-off-by: Junsung Cho <junsung@directional.net> Signed-off-by: Shashank Kumar <shashank.kumar.phe22@itbhu.ac.in>
shashankiitbhu
pushed a commit
to shashankiitbhu/web3j
that referenced
this pull request
Dec 3, 2024
) * Bug fix for FastRawTransactionManager.resetNonce Signed-off-by: Junsung Cho <junsung@directional.net> * Add check nonce after reset Signed-off-by: Junsung Cho <junsung@directional.net> --------- Signed-off-by: Junsung Cho <junsung@directional.net> Signed-off-by: Shashank Kumar <shashank.kumar.phe22@itbhu.ac.in>
shashankiitbhu
pushed a commit
to shashankiitbhu/web3j
that referenced
this pull request
Dec 3, 2024
) * Bug fix for FastRawTransactionManager.resetNonce Signed-off-by: Junsung Cho <junsung@directional.net> * Add check nonce after reset Signed-off-by: Junsung Cho <junsung@directional.net> --------- Signed-off-by: Junsung Cho <junsung@directional.net> Signed-off-by: Shashank Kumar <shashank.kumar.phe22@itbhu.ac.in>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Make
FastRawTransactionManager.resetNonce()
reset the nonceWhere should the reviewer start?
#2002
Why is it needed?
AS-IS
TO-BE
While the AS-IS reset nonce with the current nonce, if
getNonce()
is called, it will returncurrentNonce + 1
.Checklist
fix #2002