Add Pantheon JSON-RPC eth_chainId method #766
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Recently we implemented EIP-695 on Pantheon (Pantheon PR link).
In this PR, we are introducing Pantheon module with the factory for the Pantheon object that contains methods implemented by Pantheon that haven't made their way into the main JSON-RPC spec.
Where should the reviewer start?
Probably start by reviewing the tests to understand the expected behaviour. After that, review the plumbing code to ensure I didn't miss something.
Why is it needed?
As we add methods to Pantheon JSON-RPC API, it would be great to have them available on Web3j so users can keep using the library to interact with Pantheon nodes.
We are about to release Pantheon nodes running on Infura so it would be great to make things easier for the users.