Allow using java keywords as solidity function names #776
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Prepend the violating function name with "_" such that a solidity function called
double
will generate a java method called_double
. This fixes #658I am open to making this more extensible if required. For example, one could configure their own sanitizing string and specify whether it should be appended or prepended. An issue was opened on the JavaPoet github square/javapoet#690 - looks like we will have to implement ourselves in the future.
Where should the reviewer start?
SolidityFunctionWrapper
Why is it needed?
Because Solidity contract writers should not need to worry about Java keywords.