Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish crate and python wrapper #8

Open
andrewwhitehead opened this issue Aug 2, 2023 · 1 comment
Open

Publish crate and python wrapper #8

andrewwhitehead opened this issue Aug 2, 2023 · 1 comment

Comments

@andrewwhitehead
Copy link
Member

The current python wrapper lives in https://github.com/mattrglobal/ffi-bbs-signatures so it would be best to submit PRs there.

This crate should be published to crates.io (after testing the wrapper integration), and the wrapper crate updated to support linux/arm64. The main build script is at https://github.com/mattrglobal/ffi-bbs-signatures/blob/master/scripts/build.sh, where the Linux section might be updated to generate two different libraries. Currently, it doesn't appear that Cross is used, which makes me wonder whether the wrapper is actually manylinux2014 compatible. It might be good to borrow from https://github.com/hyperledger/indy-shared-rs/blob/main/.github/workflows/build.yml for checking this compatibility. It would also be useful to extend the MacOS build to create a universal binary, as it appears to be x86_64 only (supported via rosetta 2) at the moment.

@esune
Copy link
Member

esune commented Aug 1, 2024

On hold until a new BBS strategy is available to be implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants