Revisit presentation preview #187
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ealed attributes Signed-off-by: sklump <srklump@hotmail.com>
…cation timestamps to attribute spec Signed-off-by: sklump <srklump@hotmail.com>
…n cred def supporting revocation Signed-off-by: sklump <srklump@hotmail.com>
Signed-off-by: sklump <srklump@hotmail.com>
…or unrevealed and self-attested attrs Signed-off-by: sklump <srklump@hotmail.com>
kdenhartog
approved these changes
Aug 15, 2019
|
Hello,
I think I should get my protoype's unit tests to pass first. I hope I can say OK in about 24 hours (16:00 EDT), but golf off for the moment thanks.
Cheers
Stephen
…Sent from my HTC
----- Reply message -----
From: "Kyle Den Hartog" <notifications@github.com>
To: "hyperledger/aries-rfcs" <aries-rfcs@noreply.github.com>
Cc: "Stephen Klump" <srklump@hotmail.com>, "Author" <author@noreply.github.com>
Subject: [hyperledger/aries-rfcs] Revisit presentation preview (#187)
Date: Thu, Aug 15, 2019 19:08
@kdenhartog approved this pull request.
Looks good. Do you believe this is ready to be merged or do you have some more changes you'd like to make first?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#187?email_source=notifications&email_token=ACHHN3DSWPYM5WJWNBTDKV3QEXOVNA5CNFSM4IL7PDJ2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCBXQTKQ#pullrequestreview-275712426>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ACHHN3AE7J3RGQXW6743LU3QEXOVNANCNFSM4IL7PDJQ>.
|
|
Sounds good 👍 |
|
I think these are good changes and should be merged. Just noting that whichever PR is merged first (this one or #189 ), the other will have some merge conflicts that need to be resolved. |
dhh1128
approved these changes
Aug 16, 2019
|
Hello, I've got all my unit tests to pass on my prototype. I believe you should merge this as is and then we can revisit what to take out and/or add from this position of strength. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to allow for unrevealed attrs and self-attested attrs; remove non-revocation timestamps from presentation preview.