Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove aries_vcx_core as dependency of test_utils #1101

Closed
mirgee opened this issue Jan 9, 2024 · 0 comments
Closed

Remove aries_vcx_core as dependency of test_utils #1101

mirgee opened this issue Jan 9, 2024 · 0 comments
Assignees
@xprazak2

Comments

@mirgee
Copy link
Contributor

mirgee commented Jan 9, 2024

Currently it is not possible to use test_utils (which should contain primarily test-related constants, RNG and mockdata) as a dependency in aries_vcx_core tests due to a cycle, leading to code duplication.
@mirgee mirgee mentioned this issue Jan 9, 2024
Merged
xprazak2 pushed a commit that referenced this issue Jan 10, 2024
fix: move random utils from test_utils to aries_vcx_core, closes #1101
57310bf 
Signed-off-by: Ondrej Prazak <ondrej.prazak@absa.africa>
@mirgee mirgee linked a pull request Jan 10, 2024 that will close this issue
fix: move random utils from test_utils to aries_vcx_core, closes #1101 #1104
Closed
xprazak2 pushed a commit that referenced this issue Jan 10, 2024
fix: move random utils from test_utils to aries_vcx_core, closes #1101
a1adf9b 
Signed-off-by: Ondrej Prazak <ondrej.prazak@absa.africa>
xprazak2 pushed a commit to xprazak2/aries-vcx that referenced this issue Jan 12, 2024
fix: move random utils from test_utils to aries_vcx_core, closes hype…
7a6bd2e 
…rledger#1101
xprazak2 pushed a commit that referenced this issue Jan 12, 2024
fix: move random utils from test_utils to aries_vcx_core, closes #1101
0280898 
Signed-off-by: Ondrej Prazak <ondrej.prazak@absa.africa>
xprazak2 pushed a commit that referenced this issue Jan 12, 2024
fix: move random utils from test_utils to aries_vcx_core, closes #1101
1088388 
Signed-off-by: Ondrej Prazak <ondrej.prazak@absa.africa>
xprazak2 pushed a commit that referenced this issue Jan 12, 2024
fix: move random utils from test_utils to aries_vcx_core, closes #1101
783d034 
Signed-off-by: Ondrej Prazak <ondrej.prazak@absa.africa>
xprazak2 pushed a commit that referenced this issue Jan 12, 2024
fix: move random utils from test_utils to aries_vcx_core, closes #1101
3529b80 
Signed-off-by: Ondrej Prazak <ondrej.prazak@absa.africa>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xprazak2 xprazak2

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: move random utils from test_utils to aries_vcx_core, closes #1101 hyperledger/aries-vcx
3 participants
@Patrik-Stas @xprazak2 @mirgee