Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] DIDExchange request handling should require invitation key rotation #1245

Closed
gmulhearn-anonyome opened this issue Jun 26, 2024 · 0 comments · Fixed by #1278
Closed

Comments

@gmulhearn-anonyome
Copy link
Contributor

gmulhearn-anonyome commented Jun 26, 2024

Currently the DIDExchange handle_request in aries-vcx has the invitation_key parameter as optional:

invitation_key: Option<Key>,

we want to make this a required field.

there are many TODO comments about this, but essentially:

  • it is used to sign the did_rotate attachment (rotating from the invitation DID to a new DID)
  • it is currently optional as we weren't sure how to best handle implicit invitation responses (i.e. what key is used if the invitation was implicit?!)
  • however it is now more obvious that we should use the recipient key of the service that the request was sent to (as a result of implicit invitation)
  • this will need updating from Optional to required up the stack (ariesvcx->agent->aath backchannel)
  • AATH backchannel internals will need to be updated such that it will be able to pass the invitation key (i.e. the recipient of the packed didcomm message) into the handler
JamesKEbert pushed a commit that referenced this issue Aug 1, 2024
…y rotation (#1278)

* Require Inviter Key and Store in HarnessAgent

Signed-off-by: lli <lli@anonyome.com>

* Minor Clippy/Test fixes

Signed-off-by: lli <lli@anonyome.com>

* Clippy

Signed-off-by: lli <lli@anonyome.com>

* Clippy

Signed-off-by: lli <lli@anonyome.com>

* change anon unpacks to return rec_vk

Signed-off-by: lli <lli@anonyome.com>

* clippy

Signed-off-by: lli <lli@anonyome.com>

* Remove TODO comments

Signed-off-by: lli <lli@anonyome.com>

---------

Signed-off-by: lli <lli@anonyome.com>
alberto-instnt pushed a commit to instnt-inc/instnt-aries-vcx that referenced this issue Sep 10, 2024
…vitation key rotation (hyperledger#1278)

* Require Inviter Key and Store in HarnessAgent

Signed-off-by: lli <lli@anonyome.com>

* Minor Clippy/Test fixes

Signed-off-by: lli <lli@anonyome.com>

* Clippy

Signed-off-by: lli <lli@anonyome.com>

* Clippy

Signed-off-by: lli <lli@anonyome.com>

* change anon unpacks to return rec_vk

Signed-off-by: lli <lli@anonyome.com>

* clippy

Signed-off-by: lli <lli@anonyome.com>

* Remove TODO comments

Signed-off-by: lli <lli@anonyome.com>

---------

Signed-off-by: lli <lli@anonyome.com>
alberto-instnt pushed a commit to instnt-inc/instnt-aries-vcx that referenced this issue Sep 10, 2024
…vitation key rotation (hyperledger#1278)

* Require Inviter Key and Store in HarnessAgent

Signed-off-by: lli <lli@anonyome.com>

* Minor Clippy/Test fixes

Signed-off-by: lli <lli@anonyome.com>

* Clippy

Signed-off-by: lli <lli@anonyome.com>

* Clippy

Signed-off-by: lli <lli@anonyome.com>

* change anon unpacks to return rec_vk

Signed-off-by: lli <lli@anonyome.com>

* clippy

Signed-off-by: lli <lli@anonyome.com>

* Remove TODO comments

Signed-off-by: lli <lli@anonyome.com>

---------

Signed-off-by: lli <lli@anonyome.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant