Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify messages crate #697

Closed
Patrik-Stas opened this issue Dec 17, 2022 · 0 comments · Fixed by #701 or #704
Closed

Simplify messages crate #697

Patrik-Stas opened this issue Dec 17, 2022 · 0 comments · Fixed by #701 or #704
Assignees
@Patrik-Stas
Labels
refactoring

Comments

@Patrik-Stas
Copy link
Contributor

The crate should be purely data model of aries messages and its construction. The crate should have minimal number of dependencies.
Some of the obvious action steps:

  • move DID DOC stuff away (this could well be a separate crate)
  • ServiceResolvable should be moved to aries-vcx
  • review crate dependencies
@Patrik-Stas Patrik-Stas self-assigned this Dec 19, 2022
@Patrik-Stas Patrik-Stas moved this to In Progress in aries-vcx Dec 19, 2022
@Patrik-Stas Patrik-Stas moved this from In Progress to Review in aries-vcx Dec 19, 2022
This was linked to pull requests Dec 21, 2022
messages: reduce dependencies, propagate errors, remove dead code #701
Merged
Refactor diddoc, extract as crate, create crate vcx_shared #704
Merged
@Patrik-Stas Patrik-Stas mentioned this issue Dec 21, 2022
Merged
Repository owner moved this from Review to Done in aries-vcx Dec 24, 2022
@hyperledger-bot hyperledger-bot mentioned this issue Oct 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Patrik-Stas Patrik-Stas

Labels
refactoring
Projects
aries-vcx
Status: Done
Milestone
No milestone
1 participant
@Patrik-Stas