Refactor diddoc, extract as crate, create crate vcx_shared

[Patrik-Stas]

Note: The commits in these PR are quite well separated, might we worthy to review commit-by-commit approach

This PR is further addressing #697

Changes:

• Aries/w3c diddoc divergence

  • Added W3cDidDoc - this reflects https://www.w3.org/TR/did-core/#example-30-did-document-with-1-verification-method-type but is not currently used anywhere as there's a slight divergence due aries service extensions.
  • Renamed original DidDoc to AriesDidDoc
  • The difference between the 2 is most of all service attribute - the rendered diddoc resolved by did:sov has an extra attributes like recipientKeys, routingKeys etc. (see Resolver DID Document Format @ https://sovrin-foundation.github.io/sovrin/spec/did-method-spec-template.html)
  • Long term we should use W3cDidDoc or find better abstraction to fit in the aries stuff

• Renamed ServiceResolvable - which sounds like and interface but is enum, to ServiceOob. This represents either AriesService or a DiD, for which AriesService can be resolved from ledger per OOB spec https://github.com/hyperledger/aries-rfcs/blob/main/features/0434-outofband/README.md#messages

  services - an array of union types that the receiver uses when responding to the message. Each item is either a DIDComm service object (as per RFC0067) or a DID (as per Decentralized Identifiers v1.0). Additional details below.

• Moved EndpointDidSov under aries-vcx/common/ledger - it has nothing to do with Aries messages, eventually should end up in some DID DOC resolver module

• Added optional field types which was missing in EndpointDidSov (as specified in DID Service Endpoint @ https://sovrin-foundation.github.io/sovrin/spec/did-method-spec-template.html#crud-operation-definitions )

• Extracted all diddoc related code to separate crate - as by itself is more general concept and has no relation to aries

• As result, I also ended up creating vcx_shared crate to avoid yet another duplication of methods validate_did and validate_verkey

Built on top of #702

[codecov-commenter]

Codecov Report

Merging #704 (89c218f) into main (dedb0e4) will decrease coverage by 0.13%.
The diff coverage is 48.27%.

@@            Coverage Diff             @@
##             main     #704      +/-   ##
==========================================
- Coverage   64.16%   64.02%   -0.14%     
==========================================
  Files         239      246       +7     
  Lines       22646    22748     +102     
  Branches     5072     5093      +21     
==========================================
+ Hits        14530    14564      +34     
- Misses       3973     4034      +61     
- Partials     4143     4150       +7     

Flag	Coverage Δ
unittests-aries-vcx	63.88% <48.27%> (-0.15%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
agency_client/src/agency_client.rs	75.70% <0.00%> (ø)
agency_client/src/errors/mapping_sharedvcx.rs	0.00% <0.00%> (ø)
agency_client/src/lib.rs	70.58% <ø> (+5.88%)	⬆️
agency_client/src/messages/create_key.rs	52.77% <0.00%> (ø)
aries_vcx/src/common/signing.rs	72.09% <ø> (ø)
aries_vcx/src/errors/error.rs	44.44% <ø> (ø)
aries_vcx/src/errors/mapping_diddoc.rs	0.00% <0.00%> (ø)
aries_vcx/src/errors/mapping_others.rs	0.00% <ø> (ø)
aries_vcx/src/handlers/connection/public_agent.rs	39.82% <ø> (ø)
...c/protocols/connection/invitee/states/requested.rs	66.66% <0.00%> (ø)
... and 42 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[gmulhearn]

looks good, just the one comment i wasn't sure about

[Patrik-Stas]

gmulhearn thanks for the review!

Rebased and merging