Refactor: reuse parse_numalgo to avoid duplication #1020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Codecov Report
@@ Coverage Diff @@
## main #1020 +/- ##
==========================================
- Coverage 36.67% 36.53% -0.15%
==========================================
Files 369 378 +9
Lines 21811 21912 +101
Branches 4010 4035 +25
==========================================
+ Hits 8000 8005 +5
- Misses 11653 11751 +98
+ Partials 2158 2156 -2
Flags with carried forward coverage won't be shown. Click here to find out more. |
mirgee
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Micro refactor ;-) Just dipping my toes