Add mediator coordination messages to aries-vcx messages crate #1052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Naian <126972030+nain-F49FF806@users.noreply.github.com>
Signed-off-by: Naian <126972030+nain-F49FF806@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## main #1052 +/- ##
========================================
- Coverage 0.05% 0.05% -0.01%
========================================
Files 379 388 +9
Lines 20912 21031 +119
Branches 3853 3876 +23
========================================
Hits 12 12
- Misses 20899 21018 +119
Partials 1 1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
nain-F49FF806
changed the title
Signed-off-by: Naian <126972030+nain-F49FF806@users.noreply.github.com>
Signed-off-by: Naian <126972030+nain-F49FF806@users.noreply.github.com>
nain-F49FF806
changed the title
nain-F49FF806
force-pushed
the
feat/messages/mediator-coord
branch
from
d11b707
to
9a12b46
Compare
Signed-off-by: Naian <126972030+nain-F49FF806@users.noreply.github.com>
Patrik-Stas
requested changes
Nov 12, 2023
messages/src/msg_fields/protocols/coordinate_mediation/mediate_request.rs
Outdated
Show resolved
Hide resolved
messages/src/msg_fields/protocols/coordinate_mediation/keylist_query.rs
Outdated
Show resolved
Hide resolved
messages/src/msg_fields/protocols/coordinate_mediation/keylist.rs
Outdated
Show resolved
Hide resolved
Request type messages do not need to quote a thread, so use of the provided decorator is unlikely. Response type message keep decorator, since server may want to quote the request msg id in decorator. If there is use case for adding decorator fields then the custom decorator can be reincluded at that point . Signed-off-by: Naian <126972030+nain-F49FF806@users.noreply.github.com>
Signed-off-by: Naian <126972030+nain-F49FF806@users.noreply.github.com>
Signed-off-by: Naian <126972030+nain-F49FF806@users.noreply.github.com>
Patrik-Stas
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: https://github.com/hyperledger/aries-rfcs/blob/main/features/0211-route-coordination/README.md