refactor: encryption envelope #1070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Patrik-Stas
commented
Nov 26, 2023
Patrik-Stas
commented
- minor refactoring of encryption envelope which came up in progress of improving did-exchange implementation - a lot more can be done here (and will)
- On top of feature: Derive Display for all aries messages #1069, please merge that first for clean changelog
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## feature/messages-display #1070 +/- ##
===========================================================
- Coverage 0.05% 0.05% -0.01%
===========================================================
Files 471 471
Lines 24009 24015 +6
Branches 4294 4292 -2
===========================================================
Hits 13 13
- Misses 23995 24001 +6
Partials 1 1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Patrik-Stas
force-pushed
the
refactor/encryption-envelope
branch
from
ff64bf7
to
476d5e8
Compare
Patrik-Stas
force-pushed
the
feature/messages-display
branch
from
8c4bea2
to
68f2df7
Compare
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Patrik-Stas
force-pushed
the
feature/messages-display
branch
from
68f2df7
to
a861b63
Compare
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Patrik-Stas
force-pushed
the
refactor/encryption-envelope
branch
from
476d5e8
to
53f3a26
Compare
xprazak2
pushed a commit
that referenced
this pull request
Dec 6, 2023
Encryption envelope was refactored in #1070, but one log message is out of sync with the new naming.
xprazak2
pushed a commit
that referenced
this pull request
Dec 6, 2023
Encryption envelope was refactored in #1070, but one log message is out of sync with the new naming. Signed-off-by: Ondrej Prazak <ondrej.prazak@absa.africa>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.