fix(message_macros): explicit lifetime declaration #1077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add explicit static lifetime rather than let the compiler guess. As per suggestion of lint ELIDED_LIFETIMES_IN_ASSOCIATED_CONSTANT rust-lang/rust#115010 Signed-off-by: Naian <126972030+nain-F49FF806@users.noreply.github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1077 +/- ##
=====================================
Coverage 0.05% 0.05%
=====================================
Files 471 471
Lines 24009 24009
Branches 4306 4306
=====================================
Hits 13 13
Misses 23995 23995
Partials 1 1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Patrik-Stas
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add explicit static lifetime rather than let the compiler guess. As per suggestion of lint
ELIDED_LIFETIMES_IN_ASSOCIATED_CONSTANTrust-lang/rust#115010
This should fix the clippy warning we are seeing
(the ones point to
MessageTypetrait derive macro)