Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: encryption envelope APIs, tests #1082

Merged
merged 3 commits into from
Dec 8, 2023

Conversation

Patrik-Stas
Copy link
Contributor

@Patrik-Stas Patrik-Stas commented Dec 5, 2023

  • Builds on top of fix: didcomm message forwarding #1081 - please merge that first
  • Restores (and simplifies) tests of EncryptionEnvelope
  • Refactors EncryptionEnvelope by decoupling its APIs from concept of Aries messages. Even inherently didcomm !== aries, so this decoupling makes broader sense and also makes testing a lot easier.
    • The changes also represent one step towards dropping usage of legacy AriesDidDoc structure in encryption envelope
  • Deleted unused error mappings

@Patrik-Stas Patrik-Stas added the review:level-1 At least 1 approval required for merge label Dec 5, 2023
@Patrik-Stas Patrik-Stas changed the title Refactor/encryption envelope 2 refactor: encryption envelope APIs, tests Dec 5, 2023
@codecov-commenter
Copy link

codecov-commenter commented Dec 5, 2023

Codecov Report

Attention: 181 lines in your changes are missing coverage. Please review.

Comparison is base (a7bac93) 0.05% compared to head (5fc1905) 0.05%.

❗ Current head 5fc1905 differs from pull request most recent head a00160a. Consider uploading reports for the commit a00160a to get more accurate results

Files Patch % Lines
aries/aries_vcx/src/utils/encryption_envelope.rs 0.00% 161 Missing ⚠️
aries/aries_vcx_core/src/wallet/indy/signing.rs 0.00% 11 Missing ⚠️
...ries/aries_vcx_core/src/wallet/indy/indy_wallet.rs 0.00% 8 Missing ⚠️
aries/aries_vcx/tests/test_connection.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main   #1082      +/-   ##
========================================
- Coverage   0.05%   0.05%   -0.01%     
========================================
  Files        471     471              
  Lines      24019   24093      +74     
  Branches    4295    4332      +37     
========================================
  Hits          13      13              
- Misses     24005   24079      +74     
  Partials       1       1              
Flag Coverage Δ
unittests-aries-vcx 0.05% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xprazak2
Copy link
Contributor

xprazak2 commented Dec 7, 2023

Just a couple of nitpicks , looks ok to me.

Base automatically changed from fix/encryption-envelope to main December 7, 2023 12:44
@xprazak2
Copy link
Contributor

xprazak2 commented Dec 7, 2023

Needs a rebase 🥲

Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
@Patrik-Stas
Copy link
Contributor Author

@xprazak2 rebased

@xprazak2 xprazak2 merged commit 7614685 into main Dec 8, 2023
2 checks passed
@xprazak2 xprazak2 deleted the refactor/encryption-envelope-2 branch December 8, 2023 08:28
@xprazak2
Copy link
Contributor

xprazak2 commented Dec 8, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review:level-1 At least 1 approval required for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants