Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #1053 Base64URLSafe padded and unpadded decoding #1083

Merged

Conversation

lukewli-anonyome
Copy link
Contributor

@lukewli-anonyome lukewli-anonyome commented Dec 6, 2023

This PR introduces a fix for the Base64URL encoding/decoding outlined in issue #1053.

Closes #1053

@codecov-commenter
Copy link

codecov-commenter commented Dec 6, 2023

Codecov Report

Attention: 23 lines in your changes are missing coverage. Please review.

Comparison is base (882529c) 0.05% compared to head (e55d957) 0.05%.
Report is 11 commits behind head on main.

Files Patch % Lines
aries/aries_vcx/src/common/signing.rs 0.00% 23 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main   #1083      +/-   ##
========================================
- Coverage   0.05%   0.05%   -0.01%     
========================================
  Files        471     471              
  Lines      24009   24109     +100     
  Branches    4306    4336      +30     
========================================
  Hits          13      13              
- Misses     23995   24095     +100     
  Partials       1       1              
Flag Coverage Δ
unittests-aries-vcx 0.05% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gmulhearn gmulhearn added the review:level-1 At least 1 approval required for merge label Dec 7, 2023
@Patrik-Stas
Copy link
Contributor

Patrik-Stas commented Dec 7, 2023

Hi @lukewli-anonyome! Thank you for the contribution! George will handle the review here, apart from warm welcome just one small tip:
The CI is failing on formatting, you can always easily verify formatting running cargo +nightly-2023-05-08 fmt --check and fix the formatting as follows. cargo +nightly-2023-05-08 fmt --check.
We have currently hardcoded this particular nightly version of rust for formatting verification in CI, hence the strange looking command ;-)

@lukewli-anonyome lukewli-anonyome force-pushed the lli/base64PaddingTolerance branch 2 times, most recently from 0af9256 to e55d957 Compare December 18, 2023 19:51
Signed-off-by: lli <lli@anonyome.com>
Signed-off-by: lli <lli@anonyome.com>
Signed-off-by: lli <lli@anonyome.com>
Signed-off-by: lli <lli@anonyome.com>
@lukewli-anonyome lukewli-anonyome force-pushed the lli/base64PaddingTolerance branch from edb4ca0 to 50113d0 Compare December 18, 2023 21:39
Copy link
Contributor

@gmulhearn-anonyome gmulhearn-anonyome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, thanks for the effort!

@gmulhearn gmulhearn merged commit db8c27a into hyperledger:main Dec 19, 2023
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review:level-1 At least 1 approval required for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tolerance to Base64URLSafe encoding padding (or lack thereof) in Connection Protocol Signatures
5 participants