-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: #1053 Base64URLSafe padded and unpadded decoding #1083
fix: #1053 Base64URLSafe padded and unpadded decoding #1083
Conversation
7e8a3cb
to
d4e757e
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1083 +/- ##
========================================
- Coverage 0.05% 0.05% -0.01%
========================================
Files 471 471
Lines 24009 24109 +100
Branches 4306 4336 +30
========================================
Hits 13 13
- Misses 23995 24095 +100
Partials 1 1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Hi @lukewli-anonyome! Thank you for the contribution! George will handle the review here, apart from warm welcome just one small tip: |
0af9256
to
e55d957
Compare
Signed-off-by: lli <lli@anonyome.com>
Signed-off-by: lli <lli@anonyome.com>
Signed-off-by: lli <lli@anonyome.com>
Signed-off-by: lli <lli@anonyome.com>
Signed-off-by: lli <lli@anonyome.com>
edb4ca0
to
50113d0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice, thanks for the effort!
This PR introduces a fix for the Base64URL encoding/decoding outlined in issue #1053.
Closes #1053