Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Mediated Connection - Decrypt invitation request at Invitee's as No-Auth #1087

Conversation

mkempa
Copy link
Contributor

@mkempa mkempa commented Dec 11, 2023

This PR fixes an issue when Invitee is unable to decrypt connection request downloaded from mediator. The request was being attempted to decrypt as Auth when in fact it should still be No-Auth.

Signed-off-by: Matus Kempa <matus.kempa@gmail.com>
@mkempa mkempa changed the title Fix: Mediated Connection - No-auth decrypt Invitation Request at Invitee's Fix: Mediated Connection - Decrypt invitation request at Invitee's as No-Auth Dec 11, 2023
@mkempa mkempa changed the title Fix: Mediated Connection - Decrypt invitation request at Invitee's as No-Auth fix: Mediated Connection - Decrypt invitation request at Invitee's as No-Auth Dec 11, 2023
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a7bac93) 0.05% compared to head (efed260) 0.05%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##            main   #1087      +/-   ##
========================================
- Coverage   0.05%   0.05%   -0.01%     
========================================
  Files        471     471              
  Lines      24019   24093      +74     
  Branches    4295    4332      +37     
========================================
  Hits          13      13              
- Misses     24005   24079      +74     
  Partials       1       1              
Flag Coverage Δ
unittests-aries-vcx 0.05% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Patrik-Stas
Copy link
Contributor

Patrik-Stas commented Dec 12, 2023

Hi @mkempa much appreciated first contribution!

A small technical comment - Perhaps you've run into some edge case, things worked in past without this change, but I think this does no harm. - CI is passing and the Mediated Connection is generally not used anymore (though Mediated Connection is still getting tested indirectly in our NodeJS wrapper tests).

So merging ✅

@Patrik-Stas Patrik-Stas merged commit bfd2c1f into hyperledger:main Dec 12, 2023
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants