Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove libvcx_core and vcx_napi_rs crates #1145

Merged
merged 1 commit into from
Mar 14, 2024
Merged

Conversation

xprazak2
Copy link
Contributor

Removing libvcx_core and vcx_napi_rs together with their CI actions.

@xprazak2 xprazak2 force-pushed the napi-remove branch 3 times, most recently from 9642209 to b47dee8 Compare March 14, 2024 08:23
@codecov-commenter
Copy link

codecov-commenter commented Mar 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.05%. Comparing base (c2c0dde) to head (9b1c041).

❗ Current head 9b1c041 differs from pull request most recent head c7934d9. Consider uploading reports for the commit c7934d9 to get more accurate results

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1145   +/-   ##
=====================================
  Coverage   0.05%   0.05%           
=====================================
  Files        506     506           
  Lines      25477   25477           
  Branches    4638    4638           
=====================================
  Hits          13      13           
  Misses     25464   25464           
Flag Coverage Δ
unittests-aries-vcx 0.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xprazak2
Copy link
Contributor Author

Do we want to remove the js wrappers for agents as well?

@Patrik-Stas
Copy link
Contributor

@xprazak2 yes please

@xprazak2 xprazak2 force-pushed the napi-remove branch 2 times, most recently from 9b1c041 to c7934d9 Compare March 14, 2024 10:42
Signed-off-by: Ondrej Prazak <ondrej.prazak@absa.africa>

Signed-off-by: Ondrej Prazak <ondrej.prazak@absa.africa>
@Patrik-Stas Patrik-Stas merged commit 51544dd into main Mar 14, 2024
29 checks passed
@Patrik-Stas Patrik-Stas deleted the napi-remove branch March 14, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants