Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not include logger implementation in aries-vcx #1149

Merged
merged 1 commit into from
Mar 15, 2024

Conversation

Patrik-Stas
Copy link
Contributor

@Patrik-Stas Patrik-Stas commented Mar 15, 2024

  • Do not include env_logger based log implementation as part of aries_vcx - let consuming crate bring their own (mediator, aath_backchannel are already doing that)
  • As a consequence, if you consume aries_vcx, make sure to include and initialize logger implementation such as env_logger in your project to see the log messages.

Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
@codecov-commenter
Copy link

codecov-commenter commented Mar 15, 2024

Codecov Report

Attention: Patch coverage is 0% with 53 lines in your changes are missing coverage. Please review.

Project coverage is 0.05%. Comparing base (2483098) to head (5285fd5).

Files Patch % Lines
aries/misc/test_utils/src/logger.rs 0.00% 50 Missing ⚠️
aries/misc/test_utils/src/devsetup.rs 0.00% 3 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1149   +/-   ##
=====================================
  Coverage   0.05%   0.05%           
=====================================
  Files        476     476           
  Lines      24137   24134    -3     
  Branches    4498    4500    +2     
=====================================
  Hits          13      13           
+ Misses     24124   24121    -3     
Flag Coverage Δ
unittests-aries-vcx 0.05% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Patrik-Stas Patrik-Stas linked an issue Mar 15, 2024 that may be closed by this pull request
@Patrik-Stas Patrik-Stas added the review:level-1 At least 1 approval required for merge label Mar 15, 2024
@Patrik-Stas Patrik-Stas merged commit a3c5a99 into main Mar 15, 2024
25 checks passed
@Patrik-Stas Patrik-Stas deleted the change/remove-logger-implementation branch March 15, 2024 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review:level-1 At least 1 approval required for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove deps in aries-vcx: env_logger, android_logger
3 participants