Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Use typed-builder instead of custom one for VerificationMethod #1162

Merged
merged 3 commits into from
Mar 21, 2024

Conversation

Patrik-Stas
Copy link
Contributor

@Patrik-Stas Patrik-Stas commented Mar 21, 2024

  • VerificationMethod construction was designed to be done via custom builder. With little to no benefit this become even more cumbersome with introduction of DidPeer4VerificationMethod as we would have to decide to either copy the approach or settle for inconsistency in construction approach.
  • Removal of the the custom builder also enable deletion of number of tests, which were particularly aimed to test builder logic.

Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
@codecov-commenter
Copy link

codecov-commenter commented Mar 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 42 lines in your changes are missing coverage. Please review.

Project coverage is 0.05%. Comparing base (05c92f2) to head (729eb9a).

Files Patch % Lines
.../peer_did/numalgos/numalgo2/verification_method.rs 0.00% 21 Missing ⚠️
...src/peer_did/numalgos/numalgo4/encoded_document.rs 0.00% 9 Missing ⚠️
...d_methods/did_resolver_sov/src/resolution/utils.rs 0.00% 6 Missing ⚠️
...rc/protocols/did_exchange/state_machine/helpers.rs 0.00% 5 Missing ⚠️
...core/did_doc/src/schema/verification_method/mod.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##            main   #1162    +/-   ##
======================================
  Coverage   0.05%   0.05%            
======================================
  Files        485     484     -1     
  Lines      24332   24165   -167     
  Branches    4511    4489    -22     
======================================
  Hits          13      13            
+ Misses     24319   24152   -167     
Flag Coverage Δ
unittests-aries-vcx 0.05% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
@Patrik-Stas Patrik-Stas changed the title refactor: Use typed-builder instead of custom one for VerificationMethod refactor: Use typed-builder instead of custom one for VerificationMethod Mar 21, 2024
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
@gmulhearn gmulhearn merged commit 413b183 into hyperledger:main Mar 21, 2024
26 checks passed
@Patrik-Stas Patrik-Stas deleted the refactor/vm-building branch March 22, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants