Add setters on DidDocument
, remove DidDocumentBuilder
#1164
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes custom
DidDocumentBuilder
in favor of setters onDidDocument
itself.Rationale:
id
are optional, so the builder itself didn't do much in terms of assuringDidDocument
being valid. Rather then playing typical role of builder, assuring correctness of constructed datastructure,DidDocumentBuilder
was rather used in manner of signalling "mut DidDoc". You could had very well renameDidDocumentBuilder
toMutableDidDocument
and the code would had been still making sense. This made implementation somewhat awkward where DidDocument had to be converted toDidDocumentBuilder
in order to be edited (eg.DidPeerResolver
), then subsequently converted back toDidDoc
after edit.It's worth noting that the mutating method could in future performs runtime checks, such as whether a provided
DidUrl
reference (egpub fn add_authentication_ref(&mut self, reference: DidUrl)
) is referring to existingVerificationMethod
.Additionally:
DidPeer4ConstructionDidDoc