refactor: move ledger to a separate crate

[xprazak2]

Extracts ledger from aries_vcx_core and moves it to a separate crate.

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 0% with 129 lines in your changes are missing coverage. Please review.

Project coverage is 0.05%. Comparing base (d0ad7a6) to head (9c938e3).

Files	Patch %	Lines
aries/aries_vcx_ledger/src/errors/error.rs	0.00%	25 Missing ⚠️
...ies/aries_vcx_ledger/src/ledger/indy_vdr_ledger.rs	0.00%	22 Missing ⚠️
aries/aries_vcx/src/errors/mapping_ledger.rs	0.00%	17 Missing ⚠️
...ies/aries_vcx_ledger/src/errors/mapping_indyvdr.rs	0.00%	12 Missing ⚠️
aries/misc/test_utils/src/mockdata/mock_ledger.rs	0.00%	11 Missing ⚠️
...vcx/src/common/primitives/credential_definition.rs	0.00%	7 Missing ⚠️
...edger/src/errors/mapping_ledger_response_parser.rs	0.00%	6 Missing ⚠️
...ries/aries_vcx_ledger/src/errors/mapping_others.rs	0.00%	6 Missing ⚠️
aries/aries_vcx_ledger/src/ledger/common.rs	0.00%	5 Missing ⚠️
...es_vcx/src/common/proofs/prover/prover_internal.rs	0.00%	3 Missing ⚠️
... and 8 more

Additional details and impacted files

@@           Coverage Diff            @@
##            main   #1172      +/-   ##
========================================
- Coverage   0.05%   0.05%   -0.01%     
========================================
  Files        487     491       +4     
  Lines      23966   24002      +36     
  Branches    4409    4416       +7     
========================================
  Hits          13      13              
- Misses     23953   23989      +36     

Flag	Coverage Δ
unittests-aries-vcx	0.05% <0.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Patrik-Stas]

It seems that this is reason why indy_vdr was introduced as dependency - but aries_vcx shouldn't know anything about the underlying ledger implementation.

[Patrik-Stas]

Doesn't the mapping for VcxLedgerError in the file below suffice?

[xprazak2]

This file is the reason why indy_vdr is now a dependency - it was moved from aries_vcx_core. There used to be VdrError -> AriesVcxCoreErrr -> AriesVcxError conversion path but because aries_vcx_core is going away, we need to change to a direct VdrError -> AriesVcxError mapping. Alternatively, we could create an error variant in VcxLedgerError for each VdrError.

[xprazak2]

The mapping from VcxLedgerError currently does not suffice, because VcxLedgerError does not create its own variant for each VdrError but rather wrapps it

[Patrik-Stas]

Lets do the changes necessary to shield off vcx from indy-vdr, be it creating/adjusting VcxLedgerError. There's not much code relying on specific ledger error kinds (afaik the only place where we directly deal with them is when we are creating credential definition, and we have some specific behaviour based on whether the same cred-definition already exists/not exist on ledger.

[Patrik-Stas]

We can merge after this is sorted

[Patrik-Stas]

Not actionable in this PR:

It would be ideal if we use vdr_proxy_ledger, we don't actually compile and bring in indy-vdr itself (as it brings/requires all the zmq stuff with it).

I suppose the reason why this can't be done now (having 2 separate feature vdr_proxy_ledger and vdr_zmq_ledger) is because even when you use proxy implementations, I guess we are still relying on some types defined indy indy-vdr (which carries the zmq stuff).

If you can confirm my suspition, there's potential refactoring task:
Refactor indy-vdr library such that it's broken down into

• types crates
• logic

So that we can use the types, given that's necessary regardless of what transport we use, but not necessary require zmq library installed on the system if the user only intends to use proxy implementation.

[Patrik-Stas]

Left few comments, given these changes aries_vcx_core could be instead renamed to aries_vcx_anoncreds to keep consistent naming with these other extracted crates.

[xprazak2]

Left few comments, given these changes aries_vcx_core could be instead renamed to aries_vcx_anoncreds to keep consistent naming with these other extracted crates.

That will be my next step.