Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: improve mediator routes #1176

Merged
merged 1 commit into from
Apr 17, 2024
Merged

refactor: improve mediator routes #1176

merged 1 commit into from
Apr 17, 2024

Conversation

xprazak2
Copy link
Contributor

@xprazak2 xprazak2 commented Apr 9, 2024

based on #1169 (comment)

@xprazak2 xprazak2 force-pushed the med-ql branch 2 times, most recently from da41d0f to c7a56c4 Compare April 9, 2024 11:29
@nain-F49FF806
Copy link
Member

Hi, given the changes in api, we should update the readme as well. The readme has an API section with routes.

@nain-F49FF806
Copy link
Member

Also, the mediator CI was unfortunately not running. This should hopefully be fixed with #1177.
Could you do a force push again to see if it triggers it?

@nain-F49FF806
Copy link
Member

nain-F49FF806 commented Apr 12, 2024 •
edited
Loading

@xprazak2 Mediator's CI workflow seems to not have triggered still.
Perhaps we need to first merge #1177 for the updated workflow to be triggered?

When you have time, could you have a look at #1177. It's a rather small fix patch.

@nain-F49FF806
Copy link
Member

nain-F49FF806 commented Apr 16, 2024 •
edited
Loading

There seem to be two other test files with didcomm connection related functions that use the register endpoint.

  • tests/mediator-aries-connection.rs
  • tests/common/agent_and_transport_utils.rs

These can be updated to use the invitation endpoint

Other than that, lgtm.

@Patrik-Stas Patrik-Stas requested review from nain-F49FF806 and removed request for Patrik-Stas April 16, 2024 07:09
@Patrik-Stas
Copy link
Contributor

Patrik-Stas commented Apr 16, 2024 •
edited
Loading

@xprazak2 i leave nain as reviewer on this one

nain-F49FF806
nain-F49FF806 requested changes Apr 16, 2024
View reviewed changes
Copy link
Member

@nain-F49FF806 nain-F49FF806 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few minor possible improvements and nits in addition to the needed updates mentioned in previous comment

aries/agents/mediator/README.md Outdated Show resolved Hide resolved
aries/agents/mediator/tests/mediator-oob-invitation.rs Outdated Show resolved Hide resolved
aries/agents/mediator/tests/mediator-oob-invitation.rs Show resolved Hide resolved
refactor: improve mediator routes
e0918a9 
Signed-off-by: Ondrej Prazak <ondrej.prazak@absa.africa>
@xprazak2
Copy link
Contributor Author

Rebased and updated.

nain-F49FF806
nain-F49FF806 approved these changes Apr 17, 2024
View reviewed changes
Copy link
Member

@nain-F49FF806 nain-F49FF806 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Let's merge it.

@Patrik-Stas Patrik-Stas merged commit 58bbc0a into main Apr 17, 2024
25 checks passed
@Patrik-Stas Patrik-Stas deleted the med-ql branch April 17, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nain-F49FF806 nain-F49FF806 nain-F49FF806 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xprazak2 @nain-F49FF806 @Patrik-Stas