(refactor) small refactor to the new DIDExchange AnyXYZ wrappers #1249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: George Mulhearn <gmulhearn@anonyome.com>
Signed-off-by: George Mulhearn <gmulhearn@anonyome.com>
JamesKEbert
approved these changes
Jul 3, 2024
lukewli-anonyome
pushed a commit
to lukewli-anonyome/aries-vcx
that referenced
this pull request
Jul 25, 2024
…erledger#1249) * remove deserialize from any wrappers Signed-off-by: George Mulhearn <gmulhearn@anonyome.com> * simply any wrappers Signed-off-by: George Mulhearn <gmulhearn@anonyome.com> --------- Signed-off-by: George Mulhearn <gmulhearn@anonyome.com> Co-authored-by: George Mulhearn <gmulhearn@anonyome.com> Signed-off-by: lli <lli@anonyome.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started these changes mostly wanting to remove
Deserializetrait from theAnyXYZwrappers. As IMO trying to deserialize JSON back into AnyXYZ is dangerous; if both V1_0 & V1_1 variants are the same, then the serialized format is the same, so when deserializingserdecannot tell which variant it is, so it just picks the first one (misleading).Also whilst i was here... i realised the Any wrappers were duplicating themselves alot, so i made a generic enum for it