Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android script fix & Askar impl on Kotlin mobile demo #1270

Merged
merged 6 commits into from
Jul 22, 2024

Conversation

alberto-instnt
Copy link
Contributor

  • Adjusted the directory on the android script.
  • Added a AskarWallet to the Kotlin mobile demo

alberto-instnt and others added 5 commits July 8, 2024 19:09
new sh command with the new folder structure

Signed-off-by: alberto-instnt <113043904+alberto-instnt@users.noreply.github.com>
Fork sync - readme and suppressed wranings
…le demo

Signed-off-by: Alberto Leon <alberto@instnt.org>
JamesKEbert
JamesKEbert previously approved these changes Jul 22, 2024
Copy link
Contributor

@JamesKEbert JamesKEbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- although the code changes didn't appear to include anything in regards to fixing Askar (which is fine, just curious if it didn't get added accidentally or something)

Signed-off-by: Alberto Leon <alberto@instnt.org>
@alberto-instnt
Copy link
Contributor Author

@JamesKEbert Your right I missed that commit. Please review again. Thanks for the observation. Also please take a look at my implementation of keyMethod per your suggestion.

Copy link
Contributor

@JamesKEbert JamesKEbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JamesKEbert JamesKEbert merged commit f9c07c9 into hyperledger:main Jul 22, 2024
22 checks passed
lukewli-anonyome pushed a commit to lukewli-anonyome/aries-vcx that referenced this pull request Jul 25, 2024
* Updated unffi README.md

new sh command with the new folder structure

Signed-off-by: alberto-instnt <113043904+alberto-instnt@users.noreply.github.com>

* adjusted android script and added askar implementation on kotlin mobile demo

Signed-off-by: Alberto Leon <alberto@instnt.org>

* added AskarWalletConfig on mobile demo

Signed-off-by: Alberto Leon <alberto@instnt.org>

---------

Signed-off-by: alberto-instnt <113043904+alberto-instnt@users.noreply.github.com>
Signed-off-by: Alberto Leon <alberto@instnt.org>
Signed-off-by: lli <lli@anonyome.com>
alberto-instnt added a commit to instnt-inc/instnt-aries-vcx that referenced this pull request Sep 10, 2024
* Updated unffi README.md

new sh command with the new folder structure

Signed-off-by: alberto-instnt <113043904+alberto-instnt@users.noreply.github.com>

* adjusted android script and added askar implementation on kotlin mobile demo

Signed-off-by: Alberto Leon <alberto@instnt.org>

* added AskarWalletConfig on mobile demo

Signed-off-by: Alberto Leon <alberto@instnt.org>

---------

Signed-off-by: alberto-instnt <113043904+alberto-instnt@users.noreply.github.com>
Signed-off-by: Alberto Leon <alberto@instnt.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants