-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Android script fix & Askar impl on Kotlin mobile demo #1270
Android script fix & Askar impl on Kotlin mobile demo #1270
Conversation
alberto-instnt
commented
Jul 20, 2024
- Adjusted the directory on the android script.
- Added a AskarWallet to the Kotlin mobile demo
new sh command with the new folder structure Signed-off-by: alberto-instnt <113043904+alberto-instnt@users.noreply.github.com>
Updated unffi README.md
Fork sync - readme and suppressed wranings
…le demo Signed-off-by: Alberto Leon <alberto@instnt.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM -- although the code changes didn't appear to include anything in regards to fixing Askar (which is fine, just curious if it didn't get added accidentally or something)
Signed-off-by: Alberto Leon <alberto@instnt.org>
@JamesKEbert Your right I missed that commit. Please review again. Thanks for the observation. Also please take a look at my implementation of keyMethod per your suggestion. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Updated unffi README.md new sh command with the new folder structure Signed-off-by: alberto-instnt <113043904+alberto-instnt@users.noreply.github.com> * adjusted android script and added askar implementation on kotlin mobile demo Signed-off-by: Alberto Leon <alberto@instnt.org> * added AskarWalletConfig on mobile demo Signed-off-by: Alberto Leon <alberto@instnt.org> --------- Signed-off-by: alberto-instnt <113043904+alberto-instnt@users.noreply.github.com> Signed-off-by: Alberto Leon <alberto@instnt.org> Signed-off-by: lli <lli@anonyome.com>
* Updated unffi README.md new sh command with the new folder structure Signed-off-by: alberto-instnt <113043904+alberto-instnt@users.noreply.github.com> * adjusted android script and added askar implementation on kotlin mobile demo Signed-off-by: Alberto Leon <alberto@instnt.org> * added AskarWalletConfig on mobile demo Signed-off-by: Alberto Leon <alberto@instnt.org> --------- Signed-off-by: alberto-instnt <113043904+alberto-instnt@users.noreply.github.com> Signed-off-by: Alberto Leon <alberto@instnt.org>