Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(chore) update to rust 1.79 #1274

Merged
merged 2 commits into from
Jul 23, 2024
Merged

(chore) update to rust 1.79 #1274

merged 2 commits into from
Jul 23, 2024

Conversation

gmulhearn
Copy link
Contributor

Closes #1269

@gmulhearn-anonyome
update to rust 1.79 and remove warnings/errors
b27ff91 
Signed-off-by: George Mulhearn <gmulhearn@anonyome.com>
@gmulhearn-anonyome
make clippy happy
81e721a 
Signed-off-by: George Mulhearn <gmulhearn@anonyome.com>
@gmulhearn
Copy link
Contributor Author

bunch of changes in last commit to make clippy happy

JamesKEbert
JamesKEbert approved these changes Jul 23, 2024
View reviewed changes
Copy link
Contributor

@JamesKEbert JamesKEbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- expected tests passing on my end (cause I don't have the ledger running locally). Thanks for updating this!

@JamesKEbert JamesKEbert merged commit 320b1ce into hyperledger:main Jul 23, 2024
22 checks passed
lukewli-anonyome pushed a commit to lukewli-anonyome/aries-vcx that referenced this pull request Jul 25, 2024
@gmulhearn @gmulhearn-anonyome @lukewli-anonyome
(chore) update to rust 1.79 (hyperledger#1274)
f49d15d 
* update to rust 1.79 and remove warnings/errors

Signed-off-by: George Mulhearn <gmulhearn@anonyome.com>

* make clippy happy

Signed-off-by: George Mulhearn <gmulhearn@anonyome.com>

---------

Signed-off-by: George Mulhearn <gmulhearn@anonyome.com>
Co-authored-by: George Mulhearn <gmulhearn@anonyome.com>
Signed-off-by: lli <lli@anonyome.com>
alberto-instnt pushed a commit to instnt-inc/instnt-aries-vcx that referenced this pull request Sep 10, 2024
@gmulhearn @gmulhearn-anonyome @alberto-instnt
(chore) update to rust 1.79 (hyperledger#1274)
cb8181c 
* update to rust 1.79 and remove warnings/errors

Signed-off-by: George Mulhearn <gmulhearn@anonyome.com>

* make clippy happy

Signed-off-by: George Mulhearn <gmulhearn@anonyome.com>

---------

Signed-off-by: George Mulhearn <gmulhearn@anonyome.com>
Co-authored-by: George Mulhearn <gmulhearn@anonyome.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JamesKEbert JamesKEbert JamesKEbert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CI] Update to Rust 1.79 and document stable rust version
3 participants
@gmulhearn @JamesKEbert @gmulhearn-anonyome