Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) fix aath publishing #1283

Merged
merged 5 commits into from
Aug 15, 2024
Merged

(fix) fix aath publishing #1283

merged 5 commits into from
Aug 15, 2024

Conversation

gmulhearn
Copy link
Contributor

@gmulhearn gmulhearn commented Aug 15, 2024

Something changed last week where the default permissions for GITHUB_TOKEN was demoted. This meant our package publishing stopped working. This is why our backchannel image hasn't been updating.

After scavenging thru hyperledger discord, adding explicit permissions seems to fix the issue.

related discord thread: https://discord.com/channels/905194001349627914/905205991073804308/1272872860494467093

related docs: https://docs.github.com/en/actions/security-for-github-actions/security-guides/automatic-token-authentication#modifying-the-permissions-for-the-github_token

Signed-off-by: George Mulhearn <gmulhearn@anonyome.com>
Signed-off-by: George Mulhearn <gmulhearn@anonyome.com>
Signed-off-by: George Mulhearn <gmulhearn@anonyome.com>
Signed-off-by: George Mulhearn <gmulhearn@anonyome.com>
Signed-off-by: George Mulhearn <gmulhearn@anonyome.com>
Copy link
Contributor

@JamesKEbert JamesKEbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JamesKEbert JamesKEbert merged commit 8187925 into main Aug 15, 2024
22 checks passed
@JamesKEbert JamesKEbert deleted the gm/fix-aath-publishing-1 branch August 15, 2024 22:11
alberto-instnt pushed a commit to instnt-inc/instnt-aries-vcx that referenced this pull request Sep 10, 2024
* try permissions in CI

Signed-off-by: George Mulhearn <gmulhearn@anonyome.com>

* typo

Signed-off-by: George Mulhearn <gmulhearn@anonyome.com>

* change for the sake of it

Signed-off-by: George Mulhearn <gmulhearn@anonyome.com>

* try global permissions

Signed-off-by: George Mulhearn <gmulhearn@anonyome.com>

* revert and scope the permissions

Signed-off-by: George Mulhearn <gmulhearn@anonyome.com>

---------

Signed-off-by: George Mulhearn <gmulhearn@anonyome.com>
Co-authored-by: George Mulhearn <gmulhearn@anonyome.com>
alberto-instnt pushed a commit to instnt-inc/instnt-aries-vcx that referenced this pull request Sep 10, 2024
* try permissions in CI

Signed-off-by: George Mulhearn <gmulhearn@anonyome.com>

* typo

Signed-off-by: George Mulhearn <gmulhearn@anonyome.com>

* change for the sake of it

Signed-off-by: George Mulhearn <gmulhearn@anonyome.com>

* try global permissions

Signed-off-by: George Mulhearn <gmulhearn@anonyome.com>

* revert and scope the permissions

Signed-off-by: George Mulhearn <gmulhearn@anonyome.com>

---------

Signed-off-by: George Mulhearn <gmulhearn@anonyome.com>
Co-authored-by: George Mulhearn <gmulhearn@anonyome.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants