Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more integration tests, add proof request filtering by name #130

Merged
merged 5 commits into from
Oct 9, 2020

Conversation

mirgee
Copy link
Contributor

@mirgee mirgee commented Oct 7, 2020

Signed-off-by: Miroslav Kovar miroslavkovar@protonmail.com

@mirgee mirgee changed the title Add more issuance tests, add request filtering by name Add more integration tests, add proof request filtering by name Oct 7, 2020
Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>
@codecov-io
Copy link

codecov-io commented Oct 7, 2020

Codecov Report

Merging #130 into master will decrease coverage by 0.06%.
The diff coverage is 56.82%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #130      +/-   ##
==========================================
- Coverage   50.72%   50.65%   -0.07%     
==========================================
  Files         151      151              
  Lines       22975    23012      +37     
  Branches     6076     6081       +5     
==========================================
+ Hits        11653    11657       +4     
- Misses       7741     7772      +31     
- Partials     3581     3583       +2     
Flag Coverage Δ
#unittests 50.65% <56.82%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
libvcx/src/connection.rs 66.75% <0.00%> (ø)
libvcx/src/messages/get_message.rs 29.45% <ø> (ø)
libvcx/src/messages/update_message.rs 26.58% <ø> (ø)
libvcx/src/utils/devsetup.rs 25.78% <0.00%> (-1.98%) ⬇️
...aries/handlers/proof_presentation/prover/prover.rs 43.33% <27.27%> (-3.04%) ⬇️
libvcx/src/lib.rs 33.48% <77.63%> (+0.09%) ⬆️
libvcx/src/disclosed_proof_utils.rs 76.57% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65bfe25...37e0985. Read the comment docs.

Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>
Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>
Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>
libvcx/src/lib.rs Outdated Show resolved Hide resolved
libvcx/src/lib.rs Outdated Show resolved Hide resolved
libvcx/src/lib.rs Outdated Show resolved Hide resolved
libvcx/src/lib.rs Outdated Show resolved Hide resolved
libvcx/src/lib.rs Outdated Show resolved Hide resolved
libvcx/src/utils/devsetup.rs Outdated Show resolved Hide resolved
Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>
@Patrik-Stas Patrik-Stas merged commit b2b3eed into master Oct 9, 2020
@Patrik-Stas Patrik-Stas deleted the hotfix/double-issuance branch October 16, 2020 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants